Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PkClient: Successfully return when calling pk_client_adopt_async #718

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tintou
Copy link
Collaborator

@tintou tintou commented Mar 6, 2024

We had no way to return a PkResults in the correct path.

Closes #709

We had no way to return a PkResults in the correct path.
@sidt4
Copy link
Contributor

sidt4 commented Mar 7, 2024

I think #709 is fixed with this PR, but now we get a exit code: unknown for each PK transaction.

/281_ccdedeee	role         get-updates
/281_ccdedeee	sender       /usr/bin/gnome-software
/281_ccdedeee	status       finished
/281_ccdedeee	exit code: unknown
/282_eeaaecaa	allow_cancel 1
/282_eeaaecaa	percentage   100
/282_eeaaecaa	role         get-details
/282_eeaaecaa	sender       /usr/bin/gnome-software
/282_eeaaecaa	status       query
/282_eeaaecaa	status       finished
/282_eeaaecaa	exit code: unknown
/283_abdbaeeb	allow_cancel 1
/283_abdbaeeb	percentage   -1
/283_abdbaeeb	role         get-updates
/283_abdbaeeb	sender       /usr/bin/gnome-software
/283_abdbaeeb	status       wait
/283_abdbaeeb	status       finished
/283_abdbaeeb	exit code: unknown

Sample expected output:

Transactions:
 1	/450_addddedd
/450_addddedd	allow_cancel 1
/450_addddedd	percentage   -1
/450_addddedd	role         get-updates
/450_addddedd	sender       /usr/bin/gnome-software
/450_addddedd	status       setup
/450_addddedd	percentage   39
/450_addddedd	percentage   91
/450_addddedd	percentage   100
/450_addddedd	status       finished
Transactions:
 [none]
/450_addddedd	exit code: success
Transactions:
 1	/451_ddcbbcbc
/451_ddcbbcbc	allow_cancel 1
/451_ddcbbcbc	percentage   -1
/451_ddcbbcbc	role         get-details
/451_ddcbbcbc	sender       /usr/bin/gnome-software
/451_ddcbbcbc	status       setup
/451_ddcbbcbc	percentage   100
/451_ddcbbcbc	status       finished
/451_ddcbbcbc	exit code: success
Transactions:
 [none]

@ximion ximion added the incomplete Information / triage / etc. is missing to act on the issue label Mar 19, 2024
@sidt4
Copy link
Contributor

sidt4 commented May 19, 2024

This issue is addressed in #756. Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incomplete Information / triage / etc. is missing to act on the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkmon: GTask finalized without ever returning (using g_task_return_*())
3 participants