Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pk-client: Handle few error cases to avoid crash #675

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sidt4
Copy link
Contributor

@sidt4 sidt4 commented Sep 25, 2023

Without #674:

$ pkcon -p get-details /etc/passwd
Transaction:	Getting details
Status: 	Waiting in queue
The daemon crashed mid-transaction!

With #674:

$ pkcon -p get-details /etc/passwd
Transaction:	Getting details
Status: 	Waiting in queue
Status: 	Finished

(pkcon:426791): GLib-GIO-CRITICAL **: 21:26:00.688: g_simple_async_result_set_from_error: assertion 'error != NULL' failed
Trace/breakpoint trap (core dumped)

With #674 and this MR:

$ pkcon -p get-details /etc/passwd
Transaction:	Getting details
Status: 	Waiting in queue
Status: 	Finished
Results:
Fatal error: File /etc/passwd is not found or unsupported

@sidt4 sidt4 marked this pull request as draft September 25, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant