Skip to content

Commit

Permalink
PkPackage: Handle all cases for 'update-severity' property
Browse files Browse the repository at this point in the history
Fixes the following assertion failures in Debian Stable (12 /
bookworm), when there are security updates (e.g firefox)

(pkcon:23385): PackageKit-CRITICAL **: 14:13:18.629: pk_package_set_update_severity: assertion 'update_severity == PK_INFO_ENUM_UNKNOWN || update_severity == PK_INFO_ENUM_LOW || update_severity == PK_INFO_ENUM_NORMAL || update_severity == PK_INFO_ENUM_IMPORTANT || update_severity == PK_INFO_ENUM_CRITICAL' failed
  • Loading branch information
sidt4 authored and ximion committed Apr 11, 2024
1 parent a0a52ce commit 1681f34
Showing 1 changed file with 17 additions and 8 deletions.
25 changes: 17 additions & 8 deletions lib/packagekit-glib2/pk-package.c
Original file line number Diff line number Diff line change
Expand Up @@ -799,8 +799,10 @@ pk_package_class_init (PkPackageClass *klass)
/**
* PkPackage:update-severity:
*
* Can be one of %PK_INFO_ENUM_UNKNOWN, %PK_INFO_ENUM_LOW, %PK_INFO_ENUM_NORMAL,
* %PK_INFO_ENUM_IMPORTANT or %PK_INFO_ENUM_CRITICAL.
* Can be one of %PK_INFO_ENUM_UNKNOWN, %PK_INFO_ENUM_LOW,
* %PK_INFO_ENUM_ENHANCEMENT, %PK_INFO_ENUM_NORMAL,
* %PK_INFO_ENUM_BUGFIX, %PK_INFO_ENUM_IMPORTANT,
* %PK_INFO_ENUM_SECURITY or %PK_INFO_ENUM_CRITICAL.
*
* Since: 1.2.4
*/
Expand Down Expand Up @@ -888,9 +890,11 @@ pk_package_new (void)
* pk_package_get_update_severity:
* @package: a #PkPackage
*
* Returns the @package update severity. Can be one of %PK_INFO_ENUM_UNKNOWN,
* %PK_INFO_ENUM_LOW, %PK_INFO_ENUM_NORMAL, %PK_INFO_ENUM_IMPORTANT or
* %PK_INFO_ENUM_CRITICAL.
* Returns the @package update severity. Can be one of
* %PK_INFO_ENUM_UNKNOWN, %PK_INFO_ENUM_LOW,
* %PK_INFO_ENUM_ENHANCEMENT, %PK_INFO_ENUM_NORMAL,
* %PK_INFO_ENUM_BUGFIX, %PK_INFO_ENUM_IMPORTANT,
* %PK_INFO_ENUM_SECURITY or %PK_INFO_ENUM_CRITICAL.
*
* Returns: the @package update severity, if known.
*
Expand All @@ -909,9 +913,11 @@ pk_package_get_update_severity (PkPackage *package)
* @package: a #PkPackage
* @update_severity: a #PkInfoEnum
*
* Set an update severity for the @package. The @update_severity can be
* one of %PK_INFO_ENUM_UNKNOWN, %PK_INFO_ENUM_LOW, %PK_INFO_ENUM_NORMAL,
* %PK_INFO_ENUM_IMPORTANT or %PK_INFO_ENUM_CRITICAL.
* Set an update severity for the @package. The @update_severity can
* be one of %PK_INFO_ENUM_UNKNOWN, %PK_INFO_ENUM_LOW,
* %PK_INFO_ENUM_ENHANCEMENT, %PK_INFO_ENUM_NORMAL,
* %PK_INFO_ENUM_BUGFIX, %PK_INFO_ENUM_IMPORTANT,
* %PK_INFO_ENUM_SECURITY or %PK_INFO_ENUM_CRITICAL.
*
* Since: 1.2.4
**/
Expand All @@ -922,8 +928,11 @@ pk_package_set_update_severity (PkPackage *package,
g_return_if_fail (PK_IS_PACKAGE (package));
g_return_if_fail (update_severity == PK_INFO_ENUM_UNKNOWN ||
update_severity == PK_INFO_ENUM_LOW ||
update_severity == PK_INFO_ENUM_ENHANCEMENT ||
update_severity == PK_INFO_ENUM_NORMAL ||
update_severity == PK_INFO_ENUM_BUGFIX ||
update_severity == PK_INFO_ENUM_IMPORTANT ||
update_severity == PK_INFO_ENUM_SECURITY ||
update_severity == PK_INFO_ENUM_CRITICAL);

if (package->priv->update_severity == update_severity)
Expand Down

0 comments on commit 1681f34

Please sign in to comment.