Feature: Add the ability to clone an area with structures #12657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterN
reviewed
May 11, 2024
…gestions from code review Co-authored-by: Peter Nelson <peter@fuzzle.org>
StanislavShamrai
had a problem deploying
to
preview
GitHub Actions
Failure
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/clone_area_cmd.cpp
Outdated
| if (HasSignalOnTrack(iter_tile, track)) { | ||
| SignalType sigtype = GetSignalType(iter_tile, track); | ||
| SignalVariant sigvar = GetSignalVariant(iter_tile, track); | ||
| CommandCost ret = Command<CMD_BUILD_SINGLE_SIGNAL>::Do(flags, dest_tile, track_dest, sigtype, sigvar, false, false, false, SIGTYPE_BLOCK, SIGTYPE_BLOCK, 0, 0); |
Check notice
Code scanning / CodeQL
Declaration hides variable Note
src/clone_area_cmd.cpp
Outdated
| cost.AddCost(ret); | ||
| if (flags & DC_EXEC) { | ||
| if (dest_station_id == NEW_STATION) { | ||
| StationID dest_station_id = GetStationIndex(dest_tile); |
Check notice
Code scanning / CodeQL
Declaration hides variable Note
| * @param diagonal build diagonally or not. | ||
| * @return the cost of this operation or an error | ||
| */ | ||
| std::tuple<CommandCost, Money, TileIndex> CmdCloneAreaPasteProperty(DoCommandFlag flags, TileIndex tile, TileIndex area_start, [[maybe_unused]] bool diagonal) |
Check warning
Code scanning / CodeQL
Poorly documented large function Warning
StanislavShamrai
had a problem deploying
to
preview
GitHub Actions
Failure
|
The list of commits looks a bit messy, did you mean to squash it again? Additionally there are a lot of seemingly unrelated changes into table/sprites.h which might be better in a separate PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
@StanislavShamrai wants to automate a process by creating a new object using existing logic.
Description
You can build larger paths by simply copying and pasting some of the existing intersections and paths.
You can rotate an area by inserting it at a different angle.
Limitations
This was created for railroad tracks, tunnels, and bridges, but the same behavior may be added for other types of tracks and structures in the future.
Checklist for review
example:
clone-area.webm