-
-
Notifications
You must be signed in to change notification settings - Fork 844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: [AdminPort] #12411 Send Network Welcome Packet to admin port after game creation completed #12647
Conversation
Thanks for this. Please use the PR template that was prefilled in the form, it's there for a reason. 😉 To link the issue, you can write |
I think the content of the new function should become part of |
…er game creation completed Welcome moved into OnGameStart
where can i find the PR template ? |
https://github.com/OpenTTD/OpenTTD/blob/master/.github/PULL_REQUEST_TEMPLATE.md?plain=1 Furthermore please rebase instead of merge master into this branch. See https://github.com/OpenTTD/OpenTTD/blob/master/CONTRIBUTING.md for more information. As long as there are no merge conflicts, you do not need to rebase/update your branch for every change that reached master. |
Initial comment updated according to template. |
Great, thank you. Now you will have to squash all your |
…er game creation completed Welcome moved into OnGameStart
not sure if all is fine :[ |
Since this is such a simple code change, you might want to start over with Git. 😉 First, you will need to use the command line interface for GitHub — using the web interface is not powerful enough, and neither was GitHub Desktop last I tried it. If you are not doing this already, here are the instructions to set it up for OpenTTD. You will need to reset your master branch and then create a branch for this feature.
|
made some cleaning |
Motivation / Problem
ADMIN_PACKET_SERVER_WELCOME is sent too early when a newgame is issued with an external bot already connected through AdminPort.
See #12411.
Description
Move the sending of the packet to a better appropriate place when the game creation is over :
NetworkOnGameStart
Closes #12411.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.