Change: Treat extended waypoint classes as 'WAYP' class. #12618
+6
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Authors have asked for more custom waypoint classes, as lumping all waypoints into just one class gives a very big list.
My plan on the easiest way to achieve this is to treat all classes with the MSB as 0xFF as a waypoint class.
WIth #12595, this is almost implemented. However, to use the feature requires support from NewGRFs, and if they add this support then they will not work properly in 14.x
Description
So this PR is intended to provide a little "forward-compatibility" for 14.x, by translating new waypoint classes to the standard 'WAYP' class.
This maps the extended custom waypoint clases (where the first byte of the label is 0xFF) to the standard 'WAYP' label, allowing use of them before the feature exists.
Limitations
This also assumes that more-waypoint-classes plan with 0xFF as MSB is reasonable.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.