Codechange: Use smart pointers for CargoDataEntry children container #12295
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
StationViewWindow uses raw pointers and manual memory management to access and manage the tree structure in CargoDataEntry.
Description
Replace manual memory management used for the container holding leaves in the CargoDataEntry tree structure with std::unique_ptr
Limitations
Does not adjust how the children themselves are allocated, since StationViewWindow needs to obtain non-owning references to those and I haven't yet found a good way to encapsulate that.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.