Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: Use smart pointers for CargoDataEntry children container #12295

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mszabo-wikia
Copy link

@mszabo-wikia mszabo-wikia commented Mar 14, 2024

Motivation / Problem

StationViewWindow uses raw pointers and manual memory management to access and manage the tree structure in CargoDataEntry.

Description

Replace manual memory management used for the container holding leaves in the CargoDataEntry tree structure with std::unique_ptr

Limitations

Does not adjust how the children themselves are allocated, since StationViewWindow needs to obtain non-owning references to those and I haven't yet found a good way to encapsulate that.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

Replace manual memory management used for the container holding
leaves in the CargoDataEntry tree structure with std::unique_ptr.
@mszabo-wikia mszabo-wikia changed the title Codechange: Use smart pointers in StationViewWindow Codechange: Use smart pointers for CargoDataEntry children container Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant