Codechange: Make the road vehicle path cache behave more like a std::deque #12275
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
The Road Vehicle Path Cache is actually two std::deque's in one. That's a bit silly, but it is done to make saveload work. But the silliness has propaged into other parts of the code, where you basically have to push and pop items to both queues,
Description
I tried to keep the two-queues-in-one an implementation detail. From the caller's perspective it works just like a single std::deque. Sort of, because I only implemented the functions that were needed ;)
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.