New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Admin packet SERVER_WELCOME can send UINT32_MAX as seed #12411
Comments
Did not take the time to check the code for now. |
NetworkStart is called BEFORE map generation |
Here is some tested diff file made on trunk
|
Thanks for the diagnosis and proposed fix. If you'd like to propose a change to the code, please open a PR and we'd be happy to take a look. 😄 |
Ok for PR, I couldn't find how to link the PR with the issue :( |
…after game creation completed WelcomeAll moved into NetworkOnGameStart Signed-off-by: Muxy <muxy@goulp.net>
…ame creation completed WelcomeAll moved into NetworkOnGameStart Signed-off-by: Muxy <muxy@goulp.net>
Version of OpenTTD
13.4, 14.0-RC3, g9954187680, windows, linux
Expected result
after a newgame is started, the actual game seed should be sent, not the GENERATE_NEW_SEED. Seems the new seed is updated to late.
Actual result
this is the log of my admin-bot :
regular start of the bot, it get both packets and the game seed :
newgame on the console
The game seed received is GENERATE_NEW_SEED value. Dont know what to do with this.
Steps to reproduce
Start a dedicated server with admin port setup properly
connect the bot to the admin-port
receive packet protocol and welcome
launch a newgame on the console or wait for an automatic newgame
check the generation seed in the welcome packet. The value is UINT32_MAX, not the real generation seed.
The text was updated successfully, but these errors were encountered: