Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profile information to the visual test files #3270

Merged
merged 6 commits into from
May 23, 2024

Conversation

alexanderbock
Copy link
Member

@alexanderbock alexanderbock commented May 20, 2024

Instead of taking the folder name as profile, the folder is now purely for organizational purposes and used to determine the group of the test (see OpenSpace/OpenSpaceVisualTesting#4)

Closes #197

@alexanderbock alexanderbock requested a review from GPayne May 20, 2024 07:35
Copy link
Contributor

@ylvaselling ylvaselling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

My only comment is that maybe having the additional interface over the lua scripting might require more maintenance when we update the lua api, than just passing through pure lua? I suppose that would require a wait function though. Just a thought

@alexanderbock
Copy link
Member Author

It's a good point and the missing wait is definitely something that would prevent us from using it right now. I'm also thinking that we'd want some user interface to create these tests in the long run, which would be harder if they are just bare Lua scripts.

Co-authored-by: Andreas Engberg <48772850+engbergandreas@users.noreply.github.com>
@alexanderbock alexanderbock merged commit 7a2b876 into master May 23, 2024
1 check failed
@alexanderbock alexanderbock deleted the issue/197-regression-testing branch May 23, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic regression testing with rendered images
3 participants