-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: openrefine icon compliant with new MacOS guidelines #6592
base: master
Are you sure you want to change the base?
Conversation
Thanks! Pinging @OpenRefine/designers to see if they have any feedback. |
still think we can go just a bit larger... to the maximum that's allowed for the icon grid? as I mentioned in this comment #6399 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thadguidry I don't think we can go much larger because we are limited on the width by the white frame.
I'd merge this soon unless @teolemon wants to do further tweaks.
Off topic, but re
I have yet to see the designers reply to a ping. @wetneb have you been successful in getting replies by including screenshots? |
Yes we should delete this GitHub team, especially because the recommended way is to add issues/PRs to a GitHub project instead:
It looks like in this case it helped @thadguidry chime in, no? (Especially knowing that Thad generally uses Windows) |
No tweaks from me, but I'm not a designer by training 🫠 |
Fixes #6399
What