-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grel: Prepare tests for modularization #6571
Conversation
public void tearDown() { | ||
bindings = null; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have also used this opportunity to clean up unnecessary set up functions which are already included in the base class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Sorry it took me so long to review. The change summary in the PR was very helpful in wading through the volume of changes to focus on the critical parts, so thanks for that.
public void init() { | ||
functionName = "detectLanguage"; | ||
} | ||
String functionName = "detectLanguage"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems a little odd, but I guess it comes from the previous code.
Caused by merging #6571 which was already a bit old
Merging this broke the build because of a missing import, so I am adding it directly to master with 6a86001 |
Changes proposed in this pull request:
RefineTest
. This makes it possible to remove the test utilities that depend on GREL from the RefineTest class, in anticipation for it being in a core Maven module where GREL isn't availableEvalErrorTests
but really belong to the test classes for the functions they actually test. This is also necessary becauseEvalError
will live in the core Maven module (being part of the core data model, as they can be stored in Cell), whereas the corresponding functions will be in the GREL module