Update to Jetty 11 and other breaking Butterfly API changes #6077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NOTE: This was tested against a local install of the proposed Butterfly 2.0, so won't run in CI until that's published publicly somewhere. If you want to run it locally, you can checkout the Jetty 11 branch from the Butterfly repo and build and install a local version with |
Updates to Butterfly 2.0 which includes a number of breaking changes: - Jetty 11 & Servlet API 5 with new Jakarta package names - Apache commons-fileupload2 is required by the above - Velocity 2.3 - Also update package name for org.apache.commons.lang3 (apparently the version got updated as a dependency) The full set of 1.x compatibility flags from https://velocity.apache.org/engine/2.3/upgrading.html were enabled, but template authors should check the notes on that page for anything which might affect them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #{issue number here}
Changes proposed in this pull request:
This is implemented and lightly tested and appears to work, but it's a breaking change for all extensions, so I'm not convinced it's needed until there are other breaking changes needed (and perhaps not even then).