Move STR_NONE, STR_EMPTY to StringIdType.h

[AaronVanGeffen]

This entirely removes the need for StringIds.h from a few often-used headers, notably GameActionResult.h and ResultWithMessage.h.

I suggest we rename STR_NONE to something like kStringIdNone in another PR. We can discuss the new name first.

[ZehMatt]

I don't like common.h generally speaking, doing a common header violates almost always the rule of include what you need. I would rather have it StringId.h (the type and defaults like invalid) and StringIds.h (the collection/base ids)

[AaronVanGeffen]

Hmm, yes, I was also thinking it would be better to split it into a header for the Money types. I think StringId.h is a bit too similar to StringIds.h, but I would be fine with splitting it off to e.g. StringTypes.h?

Though tbh, it'll create quite the ripple effect, having to re-evaluate inclusion of common.h everywhere. Maybe we could do that in follow-up PR?

[ZehMatt]

Hmm, yes, I was also thinking it would be better to split it into a header for the Money types. I think StringId.h is a bit too similar to StringIds.h, but I would be fine with splitting it off to e.g. StringTypes.h?

Though tbh, it'll create quite the ripple effect, having to re-evaluate inclusion of common.h everywhere. Maybe we could do that in follow-up PR?

Well for the time being you could just add the StringId.h include in common.h, I don't know about the plural form of StringTypes.h, we just got StringId at the moment, if one includes the wrong header one will figure that out soon enough.

My primary concern is that defining types in common.h makes code exploration quite difficult, if someone looks for a string type its somewhat expected to have that in the file name.

[AaronVanGeffen]

Well for the time being you could just add the StringId.h include in common.h, I don't know about the plural form of StringTypes.h, we just got StringId at the moment, if one includes the wrong header one will figure that out soon enough.

I wouldn't mind including the new header in common.h for the moment, but I'd really like to avoid having a StringId.h for the type and StringIds.h for the enum.

With StringTypes.h, I was thinking we could move some types from String.hpp in there as well. I suppose that's a different kind of string types, though.

Maybe we could bring this to a vote:
🚀 StringType.h 👍 StringTypes.h 🎉 StringIdType.h?

[AaronVanGeffen]

The votes for StringIdType.h have it, so I moved the definition to a new file using that name.