Replace SCROLLABLE_ROW_HEIGHT define with constexpr kScrollableRowHeight #21906
Conversation
|
I believe that this should be ready for review, the only issue is that one of my commits had too short of a name. |
There was a problem hiding this comment.
There are a number of changes in this PR that shouldn’t be there, like one deleted file, two instances where the trailing newline was removed, and one case of an extra newline. Please fix these. The actual meat of the PR does look good, though.
Also, please do not close PRs only to recreate them - just update your existing one.
| @@ -1,3 +1,4 @@ | |||
|
|
|||
There was a problem hiding this comment.
Unrelated change, please revert.
| @@ -487,4 +487,4 @@ static void PrintLaunchInformation() | |||
| Console::WriteLine(); | |||
|
|
|||
| // TODO Print other potential information (e.g. user, hardware) | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Unrelated change, please revert.
| @@ -84,4 +84,4 @@ struct NewVersionInfo | |||
| std::string url; | |||
| }; | |||
|
|
|||
| NewVersionInfo GetLatestVersion(); | |||
| NewVersionInfo GetLatestVersion(); | |||
There was a problem hiding this comment.
Unrelated change, please revert.
| @@ -1,85 +0,0 @@ | |||
| { | |||
There was a problem hiding this comment.
Unrelated change, please revert.
Sorry about the closed PR, I was just changing which file I was working on and I'm still newer to github. I didn't know how to take out some of my old commits and only include the new ones that were relevant to this PR which was my goal with creating a new one. |
|
No worries, we have all had to learn it. Removing unwanted commits can be done using a rebase. It is an advanced operation though. For this PR, just make sure you get the diff (what is shown on the "Files changed" tab) to be correct - we’ll just squash all your commits into one. A tip for future PRs: make sure you make your changes on a branch, rather than the |
tupaschoal
changed the title
|
@katerid Could you address the line notes? |
AaronVanGeffen
changed the title
|
I intended to rebase this PR, but it looks like the |
Replacing SCROLLABLE_ROW_HEIGHT with constexpr and kScrollableRowHeight
Part of #21421