Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Part of #21421: Replace constants that use #define with ones that use constexpr #21883

Merged
merged 8 commits into from May 18, 2024
Merged

Part of #21421: Replace constants that use #define with ones that use constexpr #21883

merged 8 commits into from May 18, 2024

Conversation

rohan4412
Copy link
Contributor

@rohan4412 rohan4412 commented Apr 22, 2024 •
edited

Issue: #21421
Replaced constants that are declared with "#define" in the Options.cpp file and the Drawing.h file. The list of constants updated are:
Drawing.h:

  • MAX_SCROLLING_TEXT_MODES to kMaxScrollingTextModes

Options.cpp:

  • FRAME_RENDERING_START to kFrameRenderingStart
  • FRAME_EFFECTS_START to kFrameEffectStart
  • CONTROLS_GROUP_START to kControlsGroupStart
  • THEMES_GROUP_START to kThemesGroupStart
  • TOOLBAR_GROUP_START to kToolbarGroupStart
  • TITLE_SEQUENCE_START to kTitleSequenceStart

@rohan4412 rohan4412 changed the title Issue #21421: Replace constants that use #define in Options.cpp and Drawing.h Fix #21421: Replace constants that use #define in Options.cpp and Drawing.h Apr 22, 2024
@rohan4412 rohan4412 changed the title Fix #21421: Replace constants that use #define in Options.cpp and Drawing.h Part of #21421: Replace constants that use #define in Options.cpp and Drawing.h Apr 22, 2024
@rohan4412 rohan4412 changed the title Part of #21421: Replace constants that use #define in Options.cpp and Drawing.h Part of #21421: Replace constants that use #define with ones that use constexpr Apr 22, 2024
@rohan4412 rohan4412 marked this pull request as ready for review April 23, 2024 00:13
janclod
janclod approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@janclod janclod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 🥳 good choice of data types!

@AaronVanGeffen AaronVanGeffen enabled auto-merge (squash) May 18, 2024 10:19
@AaronVanGeffen AaronVanGeffen added this to the v0.4.12 milestone May 18, 2024
@AaronVanGeffen AaronVanGeffen merged commit 24a24e3 into OpenRCT2:develop May 18, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gymnasiast Gymnasiast Gymnasiast left review comments

@AaronVanGeffen AaronVanGeffen AaronVanGeffen approved these changes

@janclod janclod janclod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.4.12
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rohan4412 @AaronVanGeffen @Gymnasiast @janclod