Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: #21669 - Guests Ignore Price Limits #21675

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Feature: #21669 - Guests Ignore Price Limits #21675

wants to merge 3 commits into from

Conversation

Harry-Hopkinson
Copy link
Contributor

@Harry-Hopkinson Harry-Hopkinson commented Mar 26, 2024 •
edited

Adds a cheat that allows for guests to ignore the prices of rollercoasters, shop items, etc.

@Harry-Hopkinson Harry-Hopkinson marked this pull request as ready for review March 26, 2024 17:24
@Harry-Hopkinson Harry-Hopkinson force-pushed the guests-ignore-price-cheat branch 2 times, most recently from fe8733e to 0f97221 Compare March 26, 2024 20:11
@Harry-Hopkinson Harry-Hopkinson marked this pull request as draft March 26, 2024 21:59
@Harry-Hopkinson
Copy link
Contributor Author

Harry-Hopkinson commented Mar 26, 2024 •
edited

I have noticed that some of the widgets do not appear to lineup properly so I will fix that soon.
Edit: Fixed.

@ZehMatt ZehMatt added network version Network version needs updating - double check before merging! changelog This issue/PR deserves a changelog entry. park file version Requires updating the park file version number labels Mar 26, 2024
@Harry-Hopkinson Harry-Hopkinson marked this pull request as ready for review March 27, 2024 11:15
@xrgtmx
Copy link
Contributor

xrgtmx commented Mar 27, 2024

Would it be better to caption the cheat "Guests ignore high prices" ?

@ZehMatt
Copy link
Member

ZehMatt commented Mar 27, 2024

Would it be better to caption the cheat "Guests ignore high prices" ?

I think its fine the way it is, it makes them essentially ignore prices in general as there is no low price threshold in the game.

@Harry-Hopkinson
Copy link
Contributor Author

Note that I have bumped the network/park version and added a changelog entry.

@Gymnasiast Gymnasiast added this to the After v0.4.10 milestone Mar 31, 2024
@Harry-Hopkinson Harry-Hopkinson force-pushed the guests-ignore-price-cheat branch 4 times, most recently from bce6a1f to 70d4f03 Compare April 13, 2024 08:38
@ZehMatt ZehMatt modified the milestones: After v0.4.10, v0.4.11 Apr 23, 2024
@spacek531
Copy link
Contributor

I tested for about 30 minutes, toggling it on and off with prices set to $20.00. Guests refused to buy with the cheat off and would buy with the cheat on. I tested shop stalls, bathrooms, and rides. Enabling and disabling worked as expected.

@Harry-Hopkinson
Copy link
Contributor Author

Thanks a lot for testing 😃 - I have also tested a lot on quite a few parks with shops, bathrooms and rides and have not noticed anything wrong with it.

@AaronVanGeffen
Copy link
Member

Just to check, have you made sure guest's can't spend more money than they have? i.e. their balance can't go negative

@Harry-Hopkinson
Copy link
Contributor Author

Yes, I have left the code untouched which checks if the RidePrice is greater than the total cash on the Peep,

@spacek531
Copy link
Contributor

spacek531 commented Apr 29, 2024 •
edited

During my testing I checked on a few peeps and they didn't have negative money. I observed peeps thinking, "I don't have enough money for [item]" which only occurs during the price checks.

@Harry-Hopkinson Harry-Hopkinson force-pushed the guests-ignore-price-cheat branch 2 times, most recently from 80ac8a5 to 86c113b Compare April 30, 2024 15:53
@Gymnasiast Gymnasiast removed this from the v0.4.11 milestone May 1, 2024
@Harry-Hopkinson
Copy link
Contributor Author

Is this ready or is there anything else I need to do?

@AaronVanGeffen AaronVanGeffen added the pending rebase PR needs to be rebased. label May 18, 2024
@Harry-Hopkinson
Copy link
Contributor Author

Note that I have rebased this PR and moved the tip string to the UiStringIds.h file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncanspumpkin duncanspumpkin duncanspumpkin left review comments

@spacek531 spacek531 spacek531 approved these changes

@AaronVanGeffen AaronVanGeffen Awaiting requested review from AaronVanGeffen

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
changelog This issue/PR deserves a changelog entry. network version Network version needs updating - double check before merging! park file version Requires updating the park file version number pending rebase PR needs to be rebased.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Harry-Hopkinson @xrgtmx @ZehMatt @spacek531 @AaronVanGeffen @duncanspumpkin @Gymnasiast