Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigate directly to settings from url hash #2090

Merged
merged 1 commit into from
May 15, 2024

Conversation

jyeshe
Copy link
Contributor

@jyeshe jyeshe commented May 15, 2024

Validation Steps

  1. Start Lightning with demo
  2. Paste on URL http://localhost:4000/projects/4adf2644-ed4e-4f97-a24c-ab35b3cb1efa/settings#collaboration
  3. It should render the collaboration settings page

Notes for the reviewer

Navigate directly to settings from url hash and renders default panel when there is no hash.

Related issue

Fixes #1971

Review checklist

  • I have performed a self-review of my code
  • I have verified that all appropriate authorization policies (:owner, :admin, :editor, :viewer) have been implemented and tested
  • If needed, I have updated the changelog
  • Product has QA'd this feature

@jyeshe jyeshe self-assigned this May 15, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.15%. Comparing base (2aba95c) to head (c6c93ac).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2090      +/-   ##
==========================================
- Coverage   90.16%   90.15%   -0.02%     
==========================================
  Files         254      254              
  Lines        8290     8290              
==========================================
- Hits         7475     7474       -1     
- Misses        815      816       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@taylordowns2000 taylordowns2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me. thank you!

@taylordowns2000 taylordowns2000 self-requested a review May 15, 2024 15:20
Copy link
Member

@taylordowns2000 taylordowns2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch @elias-ba , yes, we should figure this out. same bug as we see here: #2064

Copy link

@christad92 christad92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am satisfied with this. LGTM

@taylordowns2000 taylordowns2000 merged commit 705bb39 into main May 15, 2024
7 of 8 checks passed
@taylordowns2000 taylordowns2000 deleted the 1971-consider-url-hash branch May 15, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Inconsistent loading issues on the settings page
3 participants