-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use monaco for dataclip viewer #2087
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2087 +/- ##
==========================================
- Coverage 90.09% 90.08% -0.01%
==========================================
Files 254 257 +3
Lines 8286 8274 -12
==========================================
- Hits 7465 7454 -11
+ Misses 821 820 -1 ☔ View full report in Codecov by Sentry. |
b6181f9
to
c45c939
Compare
49ee9dd
to
1082115
Compare
Validation Steps
How can a reviewer validate your work?
Notes for the reviewer
test/lightning_web/live/run_live/streaming_test.exs
. It was testing for the scrubbed dataclip lines, so I have moved the test to thetest/lightning_web/controllers/dataclip_controller_test.exs
.Checklist
default
browser http cache. The cache is set to expire after 1 day.Related issue
Fixes #1872
Review checklist
:owner
,:admin
,:editor
,:viewer
) have been implemented and tested