Persist run options & set at creation (not claim)

[taylordowns2000]

Requesting guidance before going further. Does this feel like the right way to address the run options issue?

Required context (pre-reading) to review:

• Janitor marks runs lost before their time #2079
• Add options column to runs table #2082

Note that if we like this idea, next we still need to:

1. remove the "get options" bit that happens during claim
2. ensure that these options are delivered properly via the channel to the worker
3. check to see which options are set by the project admin (e.g., enable dataclip storage) and which options are set by the instance administrator (e.g., max run duration)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.09%. Comparing base (ae29143) to head (b467ca6).
Report is 7 commits behind head on main.

❗ Current head b467ca6 differs from pull request most recent head 281c00d

Please upload reports for the commit 281c00d to get more accurate results.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2085   +/-   ##
=======================================
  Coverage   90.09%   90.09%           
=======================================
  Files         268      268           
  Lines        8951     8955    +4     
=======================================
+ Hits         8064     8068    +4     
  Misses        887      887           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[taylordowns2000]

@stuartc , please take a look here! context in the PR itself

[elias-ba]

@taylordowns2000 this looks like a valid way to implement this. I am not sure I can't validate it's relevancy but it seems to me as a better way of dynamically calculating the run options. Maybe wait for @stuartc to confirm that point.

[elias-ba]

@taylordowns2000 this implementation looks good to me (assuming that tests and other bits will come later)

[stuartc]

This looks good, thanks for the detailed PR.

My only comment here is that I think we should make the run options more than a type. Right now it's defined in RunWithOptions.

I think is should become an embedded schema, so using Ecto.Schema.

And then in the Run model, it becomes embeds_one :options, Run.Option

This will require some light refactoring on get_run_options on UsageLimiter on both Lightning and Thunderbolt.

I believe this change will give the run options more prominence and make 'just dumping stuff in' less of a temptation.

[stuartc]

@taylordowns2000 this implementation looks good to me (assuming that tests and other bits will come later)

Oh and yes, @taylordowns2000 - tests please!