Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable connect to github button when limiter returns an error #2078

Closed
wants to merge 1 commit into from

Conversation

midigofrank
Copy link
Collaborator

Validation Steps

How can a reviewer validate your work?

Notes for the reviewer

Related issue

Fixes #

Review checklist

  • I have performed a self-review of my code
  • I have verified that all appropriate authorization policies (:owner, :admin, :editor, :viewer) have been implemented and tested
  • If needed, I have updated the changelog
  • Product has QA'd this feature

@midigofrank midigofrank self-assigned this May 13, 2024
@midigofrank midigofrank force-pushed the disable-connect-github-button branch from 704a8de to f04e370 Compare May 13, 2024 10:02
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.17%. Comparing base (4bb8d98) to head (f04e370).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2078      +/-   ##
==========================================
+ Coverage   90.15%   90.17%   +0.02%     
==========================================
  Files         254      254              
  Lines        8285     8293       +8     
==========================================
+ Hits         7469     7478       +9     
+ Misses        816      815       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stuartc
Copy link
Member

stuartc commented May 31, 2024

@midigofrank what's happening with this? related issue?

@midigofrank
Copy link
Collaborator Author

Hmm, I cant remember exactly what happened. I think we discussed a different approach. Closing it for now. cc @christad92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants