Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require user names in registration changeset #2068

Merged
merged 1 commit into from
May 17, 2024

Conversation

midigofrank
Copy link
Collaborator

Notes for the reviewer

Currently user names are required in the user registration form, but this was not enforced in the changeset.

Related issue

Paves way for: https://github.com/OpenFn/thunderbolt/issues/125

Review checklist

  • I have performed a self-review of my code
  • I have verified that all appropriate authorization policies (:owner, :admin, :editor, :viewer) have been implemented and tested
  • If needed, I have updated the changelog
  • Product has QA'd this feature

@midigofrank midigofrank self-assigned this May 10, 2024
@midigofrank midigofrank requested a review from stuartc May 10, 2024 12:48
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.12%. Comparing base (2cdd274) to head (10b436f).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2068   +/-   ##
=======================================
  Coverage   90.12%   90.12%           
=======================================
  Files         252      252           
  Lines        8261     8261           
=======================================
  Hits         7445     7445           
  Misses        816      816           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stuartc stuartc merged commit d7d3a19 into main May 17, 2024
8 checks passed
@stuartc stuartc deleted the require-user-names-during-registration branch May 17, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants