Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for console.table in logger #674

Closed
wants to merge 1 commit into from
Closed

Conversation

mtuchi
Copy link
Contributor

@mtuchi mtuchi commented Apr 20, 2024

Short Description

This PR add support for console.table to the logger. which will make it easy to log data as a table.

This function takes one mandatory argument data, which must be an array or an object, and one additional optional parameter columns.

Still to do

  • Unit test
  • Add table arguments types ?

QA Notes

List any considerations/cases/advice for testing/QA here.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added unit tests
  • Changesets have been added (if there are production code changes)

Release branch checklist

Delete this section if this is not a release PR.

If this IS a release branch:

  • Run pnpm changeset from root to bump versions
  • Run pnpm install
  • Commit the new version numbers
  • Run pnpm changeset tag to generate tags
  • Push tags git push --tags

Tags may need updating if commits come in after the tags are first generated.

@josephjclark
Copy link
Collaborator

@mtuchi I'm gonna close this down but i'll leave the branch. This is a far harder problem than I first thought!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants