This repository has been archived by the owner on Dec 20, 2021. It is now read-only.
bitmuncher: add missing methods from stream reader #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gravestench
previously approved these changes
May 11, 2021
all: fix lint errors
|
I think, that I'll add something more here |
gucio321
commented
May 15, 2021
d2common/d2datautils/bitmuncher.go
Outdated
Comment on lines
63
to
71
| func (v *BitMuncher) GetBit() uint32 { | ||
| result := uint32(v.data[v.offset/byteLen]>>uint(v.offset%byteLen)) & oneBit | ||
| func (v *BitMuncher) GetBit() bool { | ||
| result := v.data[v.offset/byteLen] >> uint(v.offset%byteLen) & oneBit | ||
| v.offset++ | ||
| v.bitsRead++ | ||
|
|
||
| return result | ||
| return result == 1 |
There was a problem hiding this comment.
what do you think about it? result will be stored in a single-byte variable (instead of 4-byte uint32)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.