debian/rules: Use default portaudio sound #3380
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 3, 2023 21:09
Always use the default portaudio sound system, also on arm architectures. Makes for consistent sound usage, avoiding the problems related to using external programs to run sounds. Closes: OpenCPN#3333
|
I will need to test this on Ubuntu PPA build workflow for all linux platforms. Please stand by. |
|
Sure, no hurry. |
|
I opened #3454 against this PR as it seems related to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always use the default portaudio sound system, also on arm architectures. Makes for consistent sound usage, avoiding the problems related to using external programs to run sounds.
While on it, remove an unused if branch.
Closes: #3285
EDIT: Updated bug reference.