Allow system mpc #281
Open
Allow system mpc #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* src/CMakeLists.txt: Only fetch the src/mpc git submodule and define the mpc library when no system MPC is found (via pkg-config).
* src/CMakeLists.txt [!MPC_FOUND]: Add the 'mpc' sub-directory to include directory. * src/openboardview/FileFormats/GenCADFile.h: Change "mpc/mpc.h" to "mpc.h".
|
Due to the name conflict with |
|
The name conflict with GNU mpc is annoying, but given that GNU mpc doesn't ship any pkg-config file, one can be sure that 'mpc' found via pkg-config would be the orangeduck-mpc (that's how I named the package in GNU Guix to avoid the name clash). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This enables building OpenBoardView using a system-provided MPC library.
Thanks!