GenCADFile: don't duplicate shape name if it is included in device name #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some .cad files have identical data in shape and device name. Duplicating it makes display overloaded. This change skips shape name display if it is contained in device name.
|
I have a .cad Asus(?) GPU board which contains a lot of elements where device name is identical to a shape name, maybe some conversion result. For this board the duplication in disaplyed names like However, the suggested change may be opinionated, since strictly speaking "duplicated shape information is also an information". So I'm fine if this will be closed/rejected) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some .cad files have identical data in shape and device name. Duplicating it makes display overloaded.
This change skips shape name display if it is contained in device name.