PDFBridgeSumatra: Detect use of fork on runtime

[swiftgeek]

Not even using windows, and I have not seen build of the forked sumatra yet.

But tested with official 32bit sumatra 3.4.6 under wine and win10, and PDF search works!

---

To get SDL log output/stdout I had use following steps when bulding, as currently /usr/x86_64-w64-mingw32/lib/cmake/SDL2/sdl2-config.cmake from my distro package includes -mwindows unconditionally, which has unfortunate effect of disabling all stdout

mkdir win_build
cd win_build
CFLAGS='-O3 -march=native' CXXFLAGS='-O3 -march=native' cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_TOOLCHAIN_FILE=../Toolchain-mingw64.cmake ../
sed -i 's/-mwindows//g' src/openboardview/CMakeFiles/openboardview.dir/link.txt
sed -i 's/-mwindows//g' src/openboardview/CMakeFiles/openboardview.dir/linklibs.rsp
make -j3

[MattSturgeon]

I'm a bit rusty on C++, so I may say something silly. But I've had a quick once over and left some comments.

[MattSturgeon]

Suggested change

	return true; // Already determined
	return this->IsForked; // Already determined

Why can't this return this->IsForked? You don't currently use the return value when calling this method, but to me it makes sense to use this method to check if Sumatra is forked 🤔

e.g. if (this->TestFork()) { /* do stuff */ }

Should probably document what the return value is for if it's for something else (like indicating an error state)

[MattSturgeon]

This could be simplified to if (this->TestFork()); if the above suggestion is taken. Not sure how I feel about having the assignment nested in an if..else vs having an additional ternary in the assignment... I think split over two or three lines it's still fairly readable?

Suggested change

	std::wstring ddeCmd;
	this->TestFork();
	if (this->IsForked)
	ddeCmd = L"[Search(\"" + this->pdfPathString + L"\",\"" + wstr + L"\"," + (caseSensitive ? L"1" : L"0") + L")]";
	else
	ddeCmd = L"[Search(\"" + this->pdfPathString + L"\",\"" + wstr + L"\")]";
	std::wstring ddeCmd = L"[Search(\"" + this->pdfPathString + L"\",\"" + wstr + L"\""
	+ (this->TestFork() ? L"," + (caseSensitive ? L"1" : L"0") : L"") + L")]";