Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a little giant leap #220

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

bunker-bunk567
Copy link

Hi there.

i worked a couple of weeks on openboardview and am now looking for a way to publish.

included changes:

TCL embedded scripting inspired by xilinx vivado

pdf cross referencing

heuristic discovery of circuit and board layout / functional groups (using TCL)

drawing resistors as zig-zags and capacitors as plates on the board (very pretty)

@bunker-bunk567
Copy link
Author

screenshot:

https://i.imgur.com/c26ZRNn.png

the thing in the center purple MOSFET is a pdf schematic page.

@inflex
Copy link
Member

inflex commented Oct 25, 2021

Won't be able to include poppler code due to licence incompatibility (MIT vs GPLv2/3)

@bunker-bunk567
Copy link
Author

it can be made a compile time option.

a program into which GPL code has been added and from which it has been removed is no longer obliged to be licensed under the GPL.

pdf is automatically opened when a part is select clicked
thumbnail to give feedback for the brief delay when the png is decompressed
pdf window can be sticked to the screen or the board
hover and left mouse select click is automatically cross referenced
scaling and panning of the pdf window
double click to toggle between schematic sticky and floating
only setting variables that are referenced and reusing all
variables in-place. 1500% faster :-)
keybindings for pdf window
fullscreen mode and docking mode (right half of screen) for pdf window

keybindings:

s - toggle sticky
f - toggle fullscreen
d - toggle dock
q - close schematic
improements mainly to the schematic window. it is still
distorted according to the aspect ratio of the underlying window,
but everything else apparently works as it should. highlighting,
hovering, panning, zooming, position reporting, resolution switching
etc.
that turned out easier than expected
allow to pass variables to a new thread. allow detachable threads and try_join
make pdf rendering thread-safe
* all to draw nets on the board to make connectivity clear at a glance
  designed to be a hint and not intended to ever draw all nets

* different resistor value ranges can use different resistor symbols
  to make it more obvious at a glance what the resistor does

* allow moving and resizing without having to use the keyboard to hold
  down shift. the top of the schem window is sensitive to being grabbed
  for a move, the corners are sensitive to be grabbed for resizing
* allow horizontal or vertical split of the main window to draw both
  sides of the board

* split startup rcl file into sections to allow for faster thread creation

//#include "TCLDUMMY.h"

#ifdef OBV_USE_POPPLER

#error Enabling pdf rendering with poppler changes the license of openboardview. Uncomment this line to continue with this derivation of openboardview under GPL license
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this say "Comment-out this line" rather than "Uncomment"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you later committed a change commenting out this line. If this is how we're notifying users this error prompt should be un-commented when merged.

That said, ideally it'd be better if there was a prompt created by the CMAKE buildscript - something like "type yes to confirm you understand". Ideally the build script would also bundle a copy of the GPL into the build.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i just leave poppler enabled while i am working on the code. since a merge into openboardview is not in the immediate future, i don't care about it at the moment.

don't care about the cmake option. anyone able to build openboardview from source should have no problem following simple instructions. even more true about anyone planning to do a closed source derivative work.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. comment it out. for sure. sorry bout that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants