openboardview: add "unix" X11 geometry flag handling #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the unix/linux specific X11 XParseGeometry() along with the '-g <geometry>' flag to handle window sizing and positioning. To get there, added 2 fields to the 'struct global', tweaked the parse_parameters() to set the new values if provided on the command line. Refactored the call to SDL_CreateWindow() to always use the global values start_x and start_y, which both now default to SDL_WINDOWPOS_CENTERED. Added the X11 shared library target only if not on WIN32 to src/openboardview/CMakeLists.txt.
|
This is my first pull request ever, so I am sure there is something funky about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the unix/linux specific X11 XParseGeometry() along with the '-g
' flag to handle window sizing and positioning.
To get there, added 2 fields to the 'struct global', tweaked the
parse_parameters() to set the new values if provided on the command
line.
Refactored the call to SDL_CreateWindow() to always use the global
values start_x and start_y, which both now default to
SDL_WINDOWPOS_CENTERED.
Added the X11 shared library target only if not on WIN32 to
src/openboardview/CMakeLists.txt.