Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GO][Client] Generated GO Client Time Query Param Millisecond Resolution Fix #18673

Merged

Conversation

gonzogomez
Copy link
Contributor

Generated Go Client code now uses time.RFC3339Nano instead of time.RFC3339, so we do not loose the millisecond resolution.

Addresses #18672

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@lwj5 @wing328

@wing328
Copy link
Member

wing328 commented May 15, 2024

thanks for the PR. would that break users who do not need the millisecond?

@gonzogomez
Copy link
Contributor Author

thanks for the PR. would that break users who do not need the millisecond?

No problem!!
This will not be a breaking change. The t.Format(time.RFC3339Nano) call is done on a time object. The time object will return the formatted timestamp as a string regardless of whether the timestamp includes fractions of a second or not. Time object that has the following timestamp 2024-05-14 02:43:39 will still be converted to 2024-05-14T02:43:39Z with the t.Format(time.RFC3339Nano).

@wing328
Copy link
Member

wing328 commented May 19, 2024

@gonzogomez thanks for the explanation. Let's give it a try.

@wing328 wing328 merged commit ef0d10d into OpenAPITools:master May 19, 2024
15 checks passed
@wing328 wing328 added this to the 7.6.0 milestone May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants