Better Configuration #437
Merged
Better Configuration #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Craftplacer
reviewed
May 8, 2024
Lets just say they were all "necessary" changes and not me going on a minor side quest 馃槶 馃槶 |
|
looks good. Just curious about the logic of the pregenerated config files being there. other than that, this closes #407 when merged. |
Craftplacer
approved these changes
May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the old IServerConfiguration and uses the ConfigurationManager provided by Generic Host. This also makes it possible to now use environment variables to configure the server. As long as you're familiar with how people do it in asp net Core, the same would apply here. Another PR to generally improve and make this feel more .net like 馃檹馃徏 closes #407