-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better Configuration #437
Better Configuration #437
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from half of the changes you've done not matching the title of the pull request, this look fine.
Lets just say they were all "necessary" changes and not me going on a minor side quest 馃槶 馃槶 |
looks good. Just curious about the logic of the pregenerated config files being there. other than that, this closes #407 when merged. |
Replaces the old IServerConfiguration and uses the ConfigurationManager provided by Generic Host. This also makes it possible to now use environment variables to configure the server. As long as you're familiar with how people do it in asp net Core, the same would apply here. Another PR to generally improve and make this feel more .net like 馃檹馃徏 closes #407