[P2642] Remove constexpr/noexcept from defaulted special members #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
constexprness/noexceptness are automatic for defaulted special members.
And replace "explicit constexpr" with "constexpr explicit"
Quuxplusone
force-pushed
the
copyedit
branch
from
63b7c6f
to
a21c615
Compare
dalg24
reviewed
Nov 10, 2023
There was a problem hiding this comment.
The layout padded spec is following what is already in the standard https://eel.is/c++draft/mdspan.layout.left.overview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
constexprness/noexceptness are automatic for defaulted special members.
(That is, they're automatically inferred with the correct values. I have not confirmed whether all your
noexcepts here were actually always-true; it's possible that by doing this I'm removing the possibility of "roguestd::terminates," and you ought to consider that before merging.)