add/fix things related to tensors and BLAS #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffhammond
commented
May 10, 2022
•
jeffhammond
commented
- infintely is spelled wrong but also wrong in meaning. there are not infinitely more possibilities for tensors, merely combinatorially many more.
- tensors over BLAS is not optimal although it is common.
- added citations related to tensors and BLAS.
- GotoBLAS is obsolete. added OpenBLAS instead.
- added BLIS and citation.
infintely is spelled wrong but also wrong in meaning. there are not infinitely more possibilities for tensors, merely combinatorially many more.
1. tensors over BLAS is not optimal although it is common. 2. added citations related to tensors and BLAS. 3. GotoBLAS is obsolete. added OpenBLAS instead. 4. added BLIS and citation.
BLAS is an API. Netlib is an implementation. the vendors are implementing the BLAS API. they may or may not use code from Netlib (in some cases we know, in others not). also note that AMD forked BLIS, which is now cited elsewhere. AMD did not create BLIS.
mhoemmen
suggested changes
May 11, 2022
There was a problem hiding this comment.
Thanks @jeffhammond for the fixes! We should clarify that only P1673.bs needs to be edited. I'm not sure why we haven't deleted the old file blas_interface.md yet. If you have the time, it would be excellent to delete it in this PR.
| @@ -834,12 +835,16 @@ to some multi-indices in the Cartesian product of extents. | |||
| ### Tensors | |||
|
|
|||
| We exclude tensors from this proposal, for the following reasons. | |||
| First, tensor libraries naturally build on optimized dense linear | |||
| First, tensor libraries often build on optimized dense linear | |||
| algebra libraries like the BLAS, so a linear algebra library is a good | |||
There was a problem hiding this comment.
Suggested change
| algebra libraries like the BLAS, so a linear algebra library is a good | |
| algebra libraries like the BLAS. Thus, a linear algebra library is a good |
| @@ -1597,7 +1602,7 @@ pioneering efforts and history lessons. | |||
| SLATE Working Notes, Innovative Computing Laboratory, University of | |||
| Tennessee Knoxville, Feb. 2018. | |||
|
|
|||
| * K. Goto and R. A. van de Geijn, "Anatomy of high-performance matrix | |||
| * K. Goto and R. A. van de Geijn, ["Anatomy of high-performance matrix | |||
|
I added PR #231, which deletes the old |
mhoemmen
added a commit
to mhoemmen/cpp-proposals-pub
that referenced
this pull request
May 11, 2022
PR ORNL#228 by Jeff Hammond suggests changes to P1673. Some of those can be applied to P1674 as well. This PR does that.
|
@jeffhammond FYI, we applied these changes to P1674, and deleted the old |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.