Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Scalable Microgrid Example #11

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Added Scalable Microgrid Example #11

wants to merge 6 commits into from

Conversation

reid-g
Copy link
Collaborator

@reid-g reid-g commented May 8, 2024

  • Added example of scalable microgrid with arbitrary size

@reid-g
Added Scalable Microgrid Example
d00d226 
 - Added example of scalable microgrid with arbitrary size
@reid-g reid-g added the enhancement New feature or request label May 8, 2024
@reid-g reid-g requested a review from pelesh May 8, 2024 16:24
@reid-g reid-g self-assigned this May 8, 2024
@reid-g reid-g mentioned this pull request May 8, 2024
Closed
pelesh
pelesh approved these changes May 24, 2024
View reviewed changes
Copy link
Collaborator

@pelesh pelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests pass, clean example implementation. Minor corrections suggested before the merge.

CMakeLists.txt Outdated Show resolved Hide resolved
Examples/Scale_Microgrid/CMakeLists.txt Outdated Show resolved Hide resolved
@reid-g @pelesh
Update Examples/Scale_Microgrid/CMakeLists.txt
76d4e2c 
Co-authored-by: pelesh <peless@ornl.gov>
pelesh
pelesh requested changes May 24, 2024
View reviewed changes
Copy link
Collaborator

@pelesh pelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor corrections as suggested in this review would make this example cleaner.

Examples/Scale_Microgrid/Scale_Microgrid.cpp Outdated Show resolved Hide resolved
Examples/Scale_Microgrid/Scale_Microgrid.cpp Outdated Show resolved Hide resolved
Examples/Scale_Microgrid/Scale_Microgrid.cpp Outdated Show resolved Hide resolved
Examples/Scale_Microgrid/Scale_Microgrid.cpp Outdated Show resolved Hide resolved
Examples/Scale_Microgrid/Scale_Microgrid.cpp Outdated Show resolved Hide resolved
Examples/Scale_Microgrid/Scale_Microgrid.cpp Outdated Show resolved Hide resolved
Examples/Scale_Microgrid/Scale_Microgrid.cpp Outdated Show resolved Hide resolved
Examples/Scale_Microgrid/Scale_Microgrid.cpp Outdated Show resolved Hide resolved
Examples/Scale_Microgrid/Scale_Microgrid.cpp Outdated Show resolved Hide resolved
Examples/Scale_Microgrid/Scale_Microgrid.cpp Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pelesh pelesh pelesh requested changes

Assignees

@reid-g reid-g

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@reid-g @pelesh