xtest regression case 4017 #741
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the AE cipher entry functions:
ta_entry_ae_update() - return TEE_AEUpdate() instead of TEE_SUCCESS
ta_entry_ae_{en,de}crypt_final() - handle NULL buffers
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
In ta_crypt_cmd_cipher_update(), ta_crypt_cmd_cipher_do_final(), ta_crypt_cmd_ae_update(), ta_crypt_cmd_ae_encrypt_final(), and ta_crypt_cmd_ae_decrypt_final(), always return out-buffer sizes even if the function doesn't return TEEC_SUCCESS. Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
Add case 4017 "Test TEE Internal API Cipher block buffering". This test tries to test the corner cases for Cipher and AE buffering. Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
jforissier
reviewed
Apr 23, 2024
etienne-lms
reviewed
Apr 24, 2024
etienne-lms
reviewed
Apr 24, 2024
| NULL, &dlen); | ||
| if (!res) | ||
| return ADBG_EXPECT_COMPARE_UNSIGNED(c, dlen, ==, 0) && | ||
| ADBG_EXPECT_COMPARE_UNSIGNED(c, dlen, ==, out); |
There was a problem hiding this comment.
Do you mean
return ADBG_EXPECT_COMPARE_UNSIGNED(c, dlen, ==, out);?
There was a problem hiding this comment.
That works, but with a NULL output buffer it should be 0 also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on OP-TEE/optee_os#6802