Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression 1040: test interrupt notification #663

Closed
wants to merge 1 commit into from

Conversation

etienne-lms
Copy link
Contributor

(Respin of #640. Related to optee_os P-R OP-TEE/optee_os#5793 for interrupt notif to non-secure world)

Adds regression test 1040 to invoke a new Invoke test PTA command that triggers interrupt notification tests. When the command is not supported or Invoke test PTA not embedded, the test is skipped.

@github-actions
Copy link

github-actions bot commented May 4, 2023

This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label May 4, 2023
ret_orig);
if (res == TEEC_ERROR_NOT_SUPPORTED) {
/* Embedding tests is optional: warn and nicely exit */
Do_ADBG_Log(" - 1040 - skip test, not implemented");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the ADBG_EXPECT_TEEC_ERROR_ORIGIN call fails, then this doesn't help, or? The test will still end with an error?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test calls the Invoke test PTA. Line 3284 already address the case where the PTA is not embedded. Once we know the PTA is embedded, we require the PTA to answer our request, hence the test at line 3294.
Di I miss something?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After re-reading the code, I think you're right. My first impression was that this eventually could end up logging an adbg error, while still printing the "skip test".
Acked-by: Joakim Bech <joakim.bech@linaro.org>

Adds regression test 1040 to invoke a new Invoke test PTA command that
triggers interrupt notification tests. When the command is not supported
or Invoke test PTA not embedded, the test is skipped.

Acked-by: Joakim Bech <joakim.bech@linaro.org>
Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
@etienne-lms
Copy link
Contributor Author

tag applied
thanks for the review

@etienne-lms
Copy link
Contributor Author

IBART test failure due to dependency on OP-TEE/optee_os#5793.

@github-actions github-actions bot removed the Stale label May 7, 2023
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Jun 6, 2023
@etienne-lms
Copy link
Contributor Author

please keep alive

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Jul 7, 2023
@jforissier jforissier removed the Stale label Jul 7, 2023
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Aug 7, 2023
@github-actions github-actions bot closed this Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants