Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xtest: regression_6016: use 3 threads instead of 4 #662

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

jforissier
Copy link
Contributor

Since OP-TEE commit cda03b63cf30 ("Enable SHA-3 support by default") [1] regression_6016 fails when OP-TEE OS is compiled for QEMUv8 with "make CFG_ULIBS_SHARED=y CFG_WITH_PAGER=y":

  • regression_6016 Storage concurency o regression_6016.1 Storage id: 00000001 threads: 4, loops: 8 regression_6000.c:1784: xtest_teec_open_session(&arg[m].session, &storage_ta_uuid, ((void *)0), &orig) has an unexpected value: 0xffff000c = TEEC_ERROR_OUT_OF_MEMORY, expected 0x0 = TEEC_SUCCESS

Use 3 threads instead of 4 to reduce the memory footprint.

Link: [1] OP-TEE/optee_os@cda03b6

Copy link
Contributor

@etienne-lms etienne-lms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acked-by: Etienne Carriere <etienne.carriere@linaro.org>

@jenswi-linaro
Copy link
Contributor

Acked-by: Jens Wiklander <jens.wiklander@linaro.org>

Since OP-TEE commit cda03b63cf30 ("Enable SHA-3 support by default") [1]
regression_6016 fails when OP-TEE OS is compiled for QEMUv8 with
"make CFG_ULIBS_SHARED=y CFG_WITH_PAGER=y":

 * regression_6016 Storage concurency
 o regression_6016.1 Storage id: 00000001
     threads: 4, loops: 8
 regression_6000.c:1784: xtest_teec_open_session(&arg[m].session, &storage_ta_uuid, ((void *)0), &orig) has an unexpected value: 0xffff000c = TEEC_ERROR_OUT_OF_MEMORY, expected 0x0 = TEEC_SUCCESS

Use 3 threads instead of 4 to reduce the memory footprint.

Link: [1] OP-TEE/optee_os@cda03b6
Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Acked-by: Etienne Carriere <etienne.carriere@linaro.org>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>
@jforissier jforissier merged commit 178f3b1 into OP-TEE:master Apr 4, 2023
1 check passed
@jforissier jforissier deleted the xtest_6016_oom branch April 4, 2023 12:38
@gagachang
Copy link

Dear @jforissier

I have a question about the value of NUM_THREADS in this xtest 6016.
Does it depend on CFG_NUM_THREADS in optee-os configuration ?

I mean, if CFG_NUM_THREADS is 2, which is smaller than NUM_THREADS which is 3.
Will xtest 6016 be broken?

@jforissier
Copy link
Contributor Author

I mean, if CFG_NUM_THREADS is 2, which is smaller than NUM_THREADS which is 3.
Will xtest 6016 be broken?

No, it should still work. This test is kind of a stress test to make sure there is no error or crash with concurrent access, nothing more.

@gagachang
Copy link

No, it should still work. This test is kind of a stress test to make sure there is no error or crash with concurrent access, nothing more.

I see. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants