Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Storage TA ABI TEE_ObjectInfo #660

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

jenswi-linaro
Copy link
Contributor

With the updated types for GP 1.3 TEE_ObjectInfo contains elements with the type size_t. If xtest is built for AArch64 while the storage TA is built for AArch32 the ABI will become incompatible. Fix this by adding struct ta_storage_obj_info with fixed width integers only and use that in the TA ABI used by xtest.

@jforissier
Copy link
Contributor

I guess that explains the failure I'm seeing on QEMUv8 with COMPILE_S_USER=32 (namely, xtest 8017.1) 😉

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>

With the updated types for GP 1.3 TEE_ObjectInfo contains elements with
the type size_t. If xtest is built for AArch64 while the storage TA is
built for AArch32 the ABI will become incompatible. Fix this by adding
struct ta_storage_obj_info with fixed width integers only and use that
in the TA ABI used by xtest.

Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
@jenswi-linaro
Copy link
Contributor Author

Tag applied

@jforissier jforissier merged commit fec6bea into OP-TEE:master Mar 29, 2023
@jenswi-linaro jenswi-linaro deleted the storage_fix branch March 30, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants