xtest: regression 1100: add OCALL tests #434

HernanGatta · 2020-06-10T01:58:45Z

Add 10 tests that check the behaviour of the OCALL functionality. The tests
in question are detailed below:

OCALL without parameters:

Performs an OCALL without any parameters.

OCALL with value parameters (in/inout/out/in):

Performs an OCALL with value parameters and in parameter directions,
verifying that the values are transferred correctly between normal world
and secure world.

OCALL with memref parameters (in/inout/out/in):

Performs an OCALL with memref parameters and in parameter directions,
verifying that the bufers are transferred correctly between normal world
and secure world.

Close session during OCALL:

Performs an OCALL that closes the session through which the original
function invocation was performed. Ascertains that the OCALL is cancelled
and that the session is closed.

Finalize context during OCALL:

Performs an OCALL that finalizes the context through which the original
function invocation was performed. Ascertains that the OCALL is cancelled
and that the session that was originally used to perform the function
invocation is closed as a result of the context being finalized.

NULL memref param:

Verifies that OCALLs can carry memref parameters with NULL buffers in all
directions.

NULL memref param (mixed params):

Verifies that OCALLs can carry memref parameters with NULL buffers
alongside value and non-NULL memref parameters in various directions.

NULL memref param (invalid params):

Verifies that attempting to perform an OCALL with memref parameters with a
NULL buffer and a non-zero size and with a non-NULL buffer and a zero size
fails at the Internal Core API layer.

OCALL during session open:

Ascertains that the CA can receive an OCALL during session open.

Finalize context during session open OCALL:

Performs an OCALL during session open that finalizes the context via which
the session was being opened, verifies that the OCALL is cancelled, and
that the session fails to open.

Signed-off-by: Hernan Gatta hegatta@microsoft.com

jforissier

Hi @HernanGatta ,

Thanks for your work on these tests. Please see my comments below.

FYI, I have tested this on QEMUv8 with Clang 9.0.1 out of curiosity, and all went well.

ta/ocall/ta_ocall.c

ta/ocall/include/ta_ocall.h

ta/ocall/include/ta_ocall_test.h

ta/ocall/include/ta_ocall.h

ta/ocall/ta_ocall.c

jforissier · 2020-06-15T16:31:30Z

ta/ocall/include/user_ta_header_defines.h

+#define TA_UUID		TA_OCALL_UUID
+
+#define TA_FLAGS	(TA_FLAG_SINGLE_INSTANCE | \
+			 TA_FLAG_MULTI_SESSION | \


The MULTI_SESSION flag should not be needed. I mean, I know it is, due to the way the test is written (I tried running without and test_ocall_during_session_open() fails to open a session since the one initially created for the param tests is not closed yet).
I would recommend changing xtest_tee_test_1100() slightly or splitting it in two so that we can make sure OCALLs work in single instance single session TAs.

It's a good point, I was also not happy with this. I'll work on it.

host/xtest/regression_1100.c

github-actions · 2020-07-16T00:41:39Z

This pull request has been marked as stale because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 5 days. Note, that you can always re-open a closed pull request at any time.

jenswi-linaro · 2020-07-16T05:22:24Z

Removed the stale label

github-actions · 2020-08-16T00:51:47Z

This pull request has been marked as stale because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 5 days. Note, that you can always re-open a closed pull request at any time.

jenswi-linaro · 2020-08-17T05:48:22Z

Removed the stale label

jbech-linaro · 2020-08-17T07:10:36Z

I added the label "enhancement", which should prevent the bot from marking this as stale if I configured it correctly. However, I noticed that I only did that change for optee_os. I'll send similar patches to the other optee_xyz gits soon.

jforissier · 2020-08-17T07:21:13Z

@jbech-linaro good idea. I have added the enhancement label to the optee_os PR too.

jforissier · 2020-10-19T12:37:12Z

host/xtest/xtest_test.c

+#ifdef WITH_GP_TESTS
+const TEEC_UUID gp_tta_ds_uuid = TA_TTA_DS_UUID;
+#endif


Rebase error, was removed by commit c1acd29 ("xtest: remove GP test TA UUID")

Removed, thank you!

jforissier · 2020-10-19T14:28:03Z

With the erroneous GP lines removed:

Acked-by: Jerome Forissier <jerome@forissier.org>

HernanGatta · 2020-10-29T07:59:12Z

With the erroneous GP lines removed:

Acked-by: Jerome Forissier <jerome@forissier.org>

Thank you, and applied. I do still have the single instance question to resolve though, so do feel free to rescind the ack.

jforissier · 2020-10-29T09:03:52Z

With the erroneous GP lines removed:
Acked-by: Jerome Forissier <jerome@forissier.org>

Thank you, and applied. I do still have the single instance question to resolve though, so do feel free to rescind the ack.

No problem, we can take this later.

Add 10 tests that check the behaviour of the OCALL functionality. The tests in question are detailed below: OCALL without parameters: ------------------------- Performs an OCALL without any parameters. OCALL with value parameters (in/inout/out/in): ---------------------------------------------- Performs an OCALL with value parameters and in parameter directions, verifying that the values are transferred correctly between normal world and secure world. OCALL with memref parameters (in/inout/out/in): ----------------------------------------------- Performs an OCALL with memref parameters and in parameter directions, verifying that the bufers are transferred correctly between normal world and secure world. Close session during OCALL: --------------------------- Performs an OCALL that closes the session through which the original function invocation was performed. Ascertains that the OCALL is cancelled and that the session is closed. Finalize context during OCALL: ------------------------------ Performs an OCALL that finalizes the context through which the original function invocation was performed. Ascertains that the OCALL is cancelled and that the session that was originally used to perform the function invocation is closed as a result of the context being finalized. NULL memref param: ------------------ Verifies that OCALLs can carry memref parameters with NULL buffers in all directions. NULL memref param (mixed params): --------------------------------- Verifies that OCALLs can carry memref parameters with NULL buffers alongside value and non-NULL memref parameters in various directions. NULL memref param (invalid params): ----------------------------------- Verifies that attempting to perform an OCALL with memref parameters with a NULL buffer and a non-zero size and with a non-NULL buffer and a zero size fails at the Internal Core API layer. OCALL during session open: -------------------------- Ascertains that the CA can receive an OCALL during session open. Finalize context during session open OCALL: ------------------------------------------- Performs an OCALL during session open that finalizes the context via which the session was being opened, verifies that the OCALL is cancelled, and that the session fails to open. Signed-off-by: Hernan Gatta <hegatta@microsoft.com> Acked-by: Jerome Forissier <jerome@forissier.org>

HernanGatta · 2021-04-08T01:04:31Z

Latest push is a rebase only.

HernanGatta force-pushed the optee-generic-rpc-support branch 2 times, most recently from 9811147 to 15dc3f2 Compare June 10, 2020 02:18

jforissier reviewed Jun 15, 2020

View reviewed changes

github-actions bot added the Stale label Jul 16, 2020

jenswi-linaro removed the Stale label Jul 16, 2020

github-actions bot added the Stale label Aug 16, 2020

jenswi-linaro removed the Stale label Aug 17, 2020

jbech-linaro added the enhancement label Aug 17, 2020

HernanGatta force-pushed the optee-generic-rpc-support branch 3 times, most recently from cf363b9 to 5de1f7b Compare October 19, 2020 06:29

jforissier reviewed Oct 19, 2020

View reviewed changes

HernanGatta force-pushed the optee-generic-rpc-support branch from 5de1f7b to 4956c7e Compare October 29, 2020 07:56

HernanGatta force-pushed the optee-generic-rpc-support branch from 4956c7e to da00f36 Compare April 8, 2021 00:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

xtest: regression 1100: add OCALL tests #434

xtest: regression 1100: add OCALL tests #434

HernanGatta commented Jun 10, 2020 •

edited

jforissier left a comment

jforissier Jun 15, 2020

HernanGatta Oct 19, 2020 •

edited

github-actions bot commented Jul 16, 2020

jenswi-linaro commented Jul 16, 2020

github-actions bot commented Aug 16, 2020

jenswi-linaro commented Aug 17, 2020

jbech-linaro commented Aug 17, 2020 •

edited

jforissier commented Aug 17, 2020

jforissier Oct 19, 2020

HernanGatta Oct 29, 2020

jforissier commented Oct 19, 2020

HernanGatta commented Oct 29, 2020

jforissier commented Oct 29, 2020

HernanGatta commented Apr 8, 2021

xtest: regression 1100: add OCALL tests #434

Are you sure you want to change the base?

xtest: regression 1100: add OCALL tests #434

Conversation

HernanGatta commented Jun 10, 2020 • edited

OCALL without parameters:

OCALL with value parameters (in/inout/out/in):

OCALL with memref parameters (in/inout/out/in):

Close session during OCALL:

Finalize context during OCALL:

NULL memref param:

NULL memref param (mixed params):

NULL memref param (invalid params):

OCALL during session open:

Finalize context during session open OCALL:

jforissier left a comment

Choose a reason for hiding this comment

jforissier Jun 15, 2020

Choose a reason for hiding this comment

HernanGatta Oct 19, 2020 • edited

Choose a reason for hiding this comment

github-actions bot commented Jul 16, 2020

jenswi-linaro commented Jul 16, 2020

github-actions bot commented Aug 16, 2020

jenswi-linaro commented Aug 17, 2020

jbech-linaro commented Aug 17, 2020 • edited

jforissier commented Aug 17, 2020

jforissier Oct 19, 2020

Choose a reason for hiding this comment

HernanGatta Oct 29, 2020

Choose a reason for hiding this comment

jforissier commented Oct 19, 2020

HernanGatta commented Oct 29, 2020

jforissier commented Oct 29, 2020

HernanGatta commented Apr 8, 2021

HernanGatta commented Jun 10, 2020 •

edited

HernanGatta Oct 19, 2020 •

edited

jbech-linaro commented Aug 17, 2020 •

edited