drivers: Add FFA_CONSOLE based console driver for log #6843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysbnim
force-pushed
the
master
branch
3 times, most recently
from
54a282e
to
0cedbe4
Compare
jforissier
reviewed
May 17, 2024
There was a problem hiding this comment.
Hi @ysbnim, thanks for the patch! Please see my comments below.
ysbnim
force-pushed
the
master
branch
2 times, most recently
from
6a1c24f
to
908df06
Compare
jforissier
reviewed
May 21, 2024
This console driver uses FFA_CONSOLE ABI to write the trace logs. If CFG_FFA_CONSOLE is enabled, OP-TEE will try to initialize the console driver that uses FFA interface to print trace logs. Signed-off-by: Sungbae Yoo <sungbaey@nvidia.com> Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
| #include <drivers/serial.h> | ||
| #include <kernel/thread_arch.h> | ||
|
|
||
| #define FFA_CONSOLE_LOG_32 (0x8400008A) |
There was a problem hiding this comment.
This is defined in core/arch/arm/include/ffa.h already.
|
|
||
| static void ffa_console_putc(struct serial_chip *chip __unused, int ch) | ||
| { | ||
| thread_hvc(FFA_CONSOLE_LOG_32, 1, ch, 0); |
There was a problem hiding this comment.
The ABI supports printing more than one character at a time.
Can thread_smccc() be used instead to support an SPMC at EL3?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This console driver uses FFA_CONSOLE ABI to write the trace logs.
If CFG_FFA_CONSOLE is enabled, OP-TEE will try to initialize the FFA console driver.