core: mmu: fix collect_device_mem_ranges() to pass size #6811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etienne-lms
reviewed
Apr 30, 2024
There was a problem hiding this comment.
Could you mention in the header line it's FF-A/SPMC-EL2 related. Or maybe:
core: mmu: fix memory regions found from ff-a manifest
Fix the 6th parameter of add_phys_mem() in collect_device_mem_ranges()
that has to be the size of memory region and not the end address of the
region.
S-o-b: ...
Could you add a fix tag?
Fixes: 72a6827a6353 ("core: arm: SPMC obtain device memory info from DTB")
with that tag added:
Reviewed-by: Etienne Carriere <etienne.carriere@foss.st.com>
|
Thank you for your review. I changed the commit message and added fix and reviewed tag. |
Fix the 6th parameter of add_phys_mem() in collect_device_mem_ranges() that has to be the size of memory region and not the end address of the region. Fixes: 72a6827 ("core: arm: SPMC obtain device memory info from DTB") Signed-off-by: Sungbae Yoo <sungbaey@nvidia.com> Reviewed-by: Etienne Carriere <etienne.carriere@foss.st.com> Acked-by: Jens Wiklander <jens.wiklander@linaro.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 6th parameter of add_phys_mem() has to be the size of memory region and not the end address of the region.