LTC refactor sub.mk #6786
LTC refactor sub.mk #6786
Conversation
There was a problem hiding this comment.
Comment for commit "core: ltc: merge sub.mk's into a single sub.mk".
I see that some build directives are removed (-Wno-unused-variable, -Wno-unused-parameter). As for my review comment on Wno-declaration-after-statement, I'm fine with the removal but i think it should be stated in the commit message.
This change discards use of _CFG_CORE_LTC_CIPHER, _CFG_CORE_LTC_AUTHENC and _CFG_CORE_LTC_MAC. I suggest to also remove them from core/crypto.mk.
| @@ -1,8 +1,6 @@ | |||
| global-incdirs-y += include | |||
| global-incdirs-y += src/headers | |||
|
|
|||
| cflags-lib-y += -Wno-declaration-after-statement | |||
There was a problem hiding this comment.
This change remove this global libtomcrypt build directive. I'm fine with that but I think it should be stated in the commit message.
| cppflags-mpi_desc.c-y += -DMBEDTLS_ALLOW_PRIVATE_ACCESS | ||
| endif | ||
|
|
||
| srcs-y += tomcrypt.c | ||
|
|
||
| srcs-$(_CFG_CORE_LTC_AES_DESC) += src/ciphers/aes/aes.c |
There was a problem hiding this comment.
Prior this change, this source file was built only when _CFG_CORE_LTC_AES_ACCEL is disabled (core/lib/libtomcrypt/src/ciphers/aes/sub.mk).
There was a problem hiding this comment.
I'll fix up "core: ltc: merge sub.mk's into a single sub.mk" to keep this, and then clean it up in "core: ltc: sub.mk: reorganize and simplify"
core/lib/libtomcrypt/sub.mk
Outdated
|
|
||
| srcs-$(_CFG_CORE_LTC_ED25519) += src/pk/ec25519/ec25519_crypto_ctx.c | ||
| srcs-$(_CFG_CORE_LTC_ED25519) += src/pk/ec25519/ec25519_export.c | ||
| srcs-$(_CFG_CORE_LTC_ED25519) += src/pk/ec25519/tweetnacl.c |
There was a problem hiding this comment.
These 3 were built when at least one of _CFG_CORE_LTC_X25519 and _CFG_CORE_LTC_ED25519 was enabled.
There was a problem hiding this comment.
You're right, I'll fixup the commit to use _CFG_CORE_LTC_EC25519 for this.
jenswi-linaro
force-pushed
the
ltc_sub_mk
branch
from
149b65c
to
126dbb2
Compare
|
Update. I had to do it as a force push. |
|
I have prepared an update of LTC that I'll create a PR for once this is merged |
|
Nice!
|
jenswi-linaro
force-pushed
the
ltc_sub_mk
branch
from
126dbb2
to
f75f9cc
Compare
|
Tag applied |
|
@etienne-lms do you have any more comments? |
Merge all sub.mk's below core/lib/libtomcrypt/src at the end of core/lib/libtomcrypt/sub.mk. It gives an easier overview of what is compiled, but it also makes it easier when syncing core/lib/libtomcrypt/src with LTC upstream since it's out of the way. Unused sub.mk's are removed. Removes the now unused _CFG_CORE_LTC_CIPHER, _CFG_CORE_LTC_AUTHENC and _CFG_CORE_LTC_MAC from core/crypto.mk. The global LTC build flag -Wno-declaration-after-statement is removed and only supplied to the few source files that need it. Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org> Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org> Reviewed-by: Etienne Carriere <etienne.carriere@foss.st.com>
Reorganize the LTC sub.mk by collecting configuration and files in groups by algorithm or feature. Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org> Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org> Reviewed-by: Etienne Carriere <etienne.carriere@foss.st.com>
jenswi-linaro
force-pushed
the
ltc_sub_mk
branch
from
f75f9cc
to
92ad980
Compare
|
Tag applied. |
No description provided.