New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers: regulator: fix error case in regulator_supported_voltages() + split asserts #6784
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gatien or @patrickdelaunay, may I ask you to have a look at these 2 changes?
The commit description of
I let you mix my suggestion with whatever you esteem right. With this changed:
|
For the series: Acked-by: Patrick Delaunay patrick.delaunay@foss.st.com |
Thanks Gatien, indeed the sentence is far to long and not readable. |
Fix case when .supported_voltages() handler is supported. If successful it shall assert voltage description data. If it returns TEE_ERROR_NOT_SUPPORTED, it shall use the pre-filled fallback description. Fixes: af5b988 ("drivers: regulator: supported voltage consider levels bounds") Signed-off-by: Etienne Carriere <etienne.carriere@foss.st.com> Acked-by: Gatien Chevallier <gatien.chevallier@foss.st.com> Acked-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
Split assertions in regulator_supported_voltages() to ease debugging, providing a better indication of which condition is not fulfilled. Signed-off-by: Etienne Carriere <etienne.carriere@foss.st.com> Acked-by: Gatien Chevallier <gatien.chevallier@foss.st.com> Acked-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
I've rephrased in 1st commit message and applied the review patches to both. |
This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note, that you can always re-open a closed issue at any time. |
2 changes:
.supported_voltages()
handler is supported to assert voltage description when the handler succeeds and to use pre-filled fallback description when the handler returnsTEE_ERROR_NOT_SUPPORTED
instead of asserting @*desc content while that pointer was likely not initialized with a valid address.Fixes: af5b988 ("drivers: regulator: supported voltage consider levels bounds")
regulator_supported_voltages()
to ease debugging, providing a better indication of which condition is not fulfilled.