drivers: crypto: remove assertions on device handlers #6782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tbourgoi, could you have a look at this change? |
|
Hello, |
Remove assertions added by the commit referred below. They are useless since the handlers are registered only if the related device (stm32_cryp or stm32_saes) has its driver successfully probed. These assertion also prevent enabling both CFG_STM32_SAES and CFG_STM32_CRYP for a platform which is a valid configuration for when we rely on the DT to state which of both is enabled. Fixes: 03de2c7 ("drivers: crypto: stm32_saes: fallback to software on 192bit AES keys") Signed-off-by: Etienne Carriere <etienne.carriere@foss.st.com> Reviewed-by: Thomas Bourgoin <thomas.bourgoin@foss.st.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove assertions added by the commit referred below. They are useless since the handlers are registered only if the related device (stm32_cryp or stm32_saes) has its driver successfully probed. These assertion also prevent enabling both CFG_STM32_SAES and CFG_STM32_CRYP for a platform which is a valid configuration for when we rely on the DT to state which of both is enabled.
Fixes: 03de2c7 ("drivers: crypto: stm32_saes: fallback to software on 192bit AES keys")