drivers:implement HiSilicon Security Engine(SEC) module. #6776
Conversation
|
I`m sorry to close the previous PR by mistake. I submitted a new PR based on HPRE.Please review it again. Thank you very much.#6689 |
| return hisi_qm_init(qm); | ||
| } | ||
|
|
||
| static struct acc_device *sec_pre_init(void) |
There was a problem hiding this comment.
Nitpicking: for consistency, I suggest to rename this function sec_alloc() and implement its counter part:
static void sec_free(struct acc_device *sec_dev)
{
SLIST_REMOVE_HEAD(&sec_list, link);
free(sec_dev);
}| #ifndef __SEC_MAIN_H | ||
| #define __SEC_MAIN_H | ||
|
|
||
| #include <initcall.h> |
There was a problem hiding this comment.
initcall.h not needed in the header file. Prefer include it from sec_main.c
Add #include <stdint.h>.
| * Copyright 2022-2024 HiSilicon Limited. | ||
| * Kunpeng hardware accelerator SEC module init. | ||
| */ | ||
| #include "sec_main.h" |
There was a problem hiding this comment.
+#include <io.h>
+#include <malloc.h>
+#include <sys/queue.h>
+#include <trace.h>
+#include <util.h>
#include "sec_main.h"
|
The review comments have been modified. Please review it again. Thank you very much. @etienne-lms @jenswi-linaro |
| #include <trace.h> | ||
| #include <util.h> | ||
| #include <initcall.h> | ||
| #include "sec_main.h" |
There was a problem hiding this comment.
sec_main.h is in the include path so <> should be used instead.
| #ifndef __SEC_MAIN_H | ||
| #define __SEC_MAIN_H | ||
|
|
||
| #include "hisi_qm.h" |
There was a problem hiding this comment.
hisi_qm.h is in the include path so please use <> instead.
| { | ||
| struct hisi_qm *qm = &sec_dev->qm; | ||
|
|
||
| qm->io_base = (uintptr_t)phys_to_virt_io(sec_dev->io_base, |
|
|
||
| val = io_read32(qm->io_base + SEC_CORE_INT_SOURCE); | ||
| if (val & SEC_RAS_NFE_ENB_MASK) { | ||
| EMSG("SEC NFE RAS happened, need to reset"); |
There was a problem hiding this comment.
Is someone supposed to read this and do something?
There was a problem hiding this comment.
Just a debug info.
There was a problem hiding this comment.
Please use DMSG() for debug info.
There was a problem hiding this comment.
The function returns an error code so I think it's fair it uses here the EMSG() macro.
There was a problem hiding this comment.
I think so, and I didn't make the change.
| qm->vfs_num = sec_dev->vfs_num; | ||
| qm->sqe_size = SEC_SQE_SIZE; | ||
| qm->sqe_log2_size = SEC_SQE_LOG2_SIZE; | ||
| if (qm->fun_type == HISI_QM_HW_PF) { |
There was a problem hiding this comment.
This is always true, but I assume that might change later. If this is false, does it still make sense to print something about the version or the state of the initialization?
There was a problem hiding this comment.
if this is false, it won't print the information.
|
Hi, does this patch still need to be modified? If not, please merge it. @jenswi-linaro |
There was a problem hiding this comment.
There are 2 comments from @jenswi-linaro that have no answers.
I've added a minor conment.
|
|
|
Hi @jforissier ,all review comments have been modified. Can you help me merge the patch? |
|
@LeiSen62 please add @jenswi-linaro's Acked-by. Perhaps @etienne-lms wants to give one, too. |
HiSilicon SEC is used in security applications such as authentication and data encryption and decryption. This module implement the hardware initialization of the SEC. Signed-off-by: leisen <leisen1@huawei.com> Acked-by: Jens Wiklander <jens.wiklander@linaro.org> Acked-by: Etienne Carriere <etienne.carriere@foss.st.com>
|
Hi @jforissier , I had added jenswi-linaro's and etienne-lms`s Acked-by. |
@etienne-lms has not given an Acked-by yet unless I missed something. |
|
Hi @etienne-lms, your review comments have been modified, Can you give an Acked-by? |
|
Hi @jforissier, can you help me to merge the patch? |
Done, thank you! |
HiSilicon SEC is used in security applications such as authentication and data encryption and decryption. This module implement the hardware initialization of the SEC.