Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instructions for Rust application #240

Merged
merged 1 commit into from
May 29, 2024

Conversation

jforissier
Copy link
Contributor

The Rust applications are now built by default on QEMUv8. Update the build instructions accordingly.

Copy link
Contributor

@msgilligan msgilligan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have verified that RUST_ENABLE=n works as documented.

Copy link
Contributor

@jenswi-linaro jenswi-linaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>

@jbech-linaro
Copy link
Contributor

Looks like there is an requirement/version error, hence readthedocs fails to render it.

@jbech-linaro
Copy link
Contributor

jbech-linaro commented May 29, 2024

@jforissier I checked this a bit and I believe the issue here is that your branch is on an older commit which doesn't have the fixes I did in commit 587e690. Can you please just simply rebase this on top of master and force push. I'm pretty sure that will fix the build error seen at readthedocs.

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>

The Rust applications are now built by default on QEMUv8. Update the
build instructions accordingly.

Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Reviewed-by: Joakim Bech <joakim.bech@linaro.org>
@jbech-linaro jbech-linaro merged commit eaa236c into OP-TEE:master May 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants