Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rt): allow rendering of points in RT Struct #4128

Merged
merged 9 commits into from
May 21, 2024
Merged

Conversation

IbrahimCSAE
Copy link
Collaborator

Context

This PR will build after the CS PR is merged here cornerstonejs/cornerstone3D#1249

this PR allows use to render single point segments in RT, previously they would show up as nothing since 1 point was not enough to create the SVG.

Changes & Results

Before:

image

After:

image

Copy link

netlify bot commented May 15, 2024

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit 7350b65
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/664d080077527a000771cfad
😎 Deploy Preview https://deploy-preview-4128--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 15, 2024

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 7350b65
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/664d0800d03451000822942a
😎 Deploy Preview https://deploy-preview-4128--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@IbrahimCSAE IbrahimCSAE requested a review from sedghi May 15, 2024 13:09
Copy link

cypress bot commented May 15, 2024

Passing run #3941 ↗︎

0 43 0 0 Flakiness 0

Details:

Merge branch 'master' of github.com:OHIF/Viewers into feat/rt-render-points
Project: Viewers Commit: 7350b65ff0
Status: Passed Duration: 06:06 💡
Started: May 21, 2024 9:07 PM Ended: May 21, 2024 9:13 PM

Review all test suite changes for PR #4128 ↗︎

@sedghi sedghi merged commit 5903b07 into master May 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants