Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui_SelectComponent): select multi selections mode should show label in dropdown not value #4054

Closed

Conversation

edwardyangxin
Copy link
Contributor

For ui Select component when isMulti=True, it should show props.label in dropdown not props.value

Context

Changes & Results

Testing

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • OS: macOS 14.4.1
  • Node version: 21.6.2
  • Browser:
    Chrome 123.0.6312.59

Copy link

netlify bot commented Apr 21, 2024

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit a185022
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/6624a5f3151a320008ecefd4
😎 Deploy Preview https://deploy-preview-4054--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 21, 2024

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit a185022
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/6624a5f3480c4b00087e8472
😎 Deploy Preview https://deploy-preview-4054--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.41%. Comparing base (8a335bd) to head (a185022).
Report is 336 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4054      +/-   ##
==========================================
- Coverage   46.23%   44.41%   -1.83%     
==========================================
  Files          78       80       +2     
  Lines        1276     1333      +57     
  Branches      312      327      +15     
==========================================
+ Hits          590      592       +2     
- Misses        548      588      +40     
- Partials      138      153      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sedghi
Copy link
Member

sedghi commented Apr 22, 2024

can you send the screenshot of before and after please?

@edwardyangxin
Copy link
Contributor Author

show props.label in dropdown not props.value

multi select with test options.
test select options:
[
{
value: "key1",
label: "value1",
},
{
value: "key2",
label: "value2",
},
{
value: "key3",
label: "value3",
},
{
value: "key4",
label: "value4",
},
{
value: "key5",
label: "value5",
},
]

before(showing values in dropdown):
image

after(showing lables in dropdown):
image

@sedghi sedghi requested a review from IbrahimCSAE May 24, 2024 16:28
@sedghi
Copy link
Member

sedghi commented May 27, 2024

We are moving towards a more comprehensive UI for multi-select. Please stay tuned. As a result, I'm going to hold off on this PR.

@sedghi sedghi removed the request for review from IbrahimCSAE May 27, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants